Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proto3 #37

Open
Downchuck opened this issue Mar 11, 2015 · 7 comments
Open

Support proto3 #37

Downchuck opened this issue Mar 11, 2015 · 7 comments

Comments

@Downchuck
Copy link

https://github.com/google/protobuf/blob/master/CHANGES.txt

"In proto3, the language is simplified, both for ease of use and to
make it available in a wider range of programming languages. At the
same time a few features are added to better support common idioms
found in APIs."

@msoucy
Copy link
Owner

msoucy commented Mar 11, 2015

I would _love_ to do this, but at the moment I've got way too much to deal with...plus even the 2.x line isn't up to date. I did take a look at some of the changes, and I think they're great.

@Downchuck
Copy link
Author

I completely understand -- it's my intention to submit a couple of pull requests.
The code base for dproto is wonderfully accessible.

@msoucy
Copy link
Owner

msoucy commented Mar 11, 2015

Why thank you! I have to thank Square for their initial protoparser that I based this parser off of, but I'm glad that it's accessible. That was one of my goals for the project.

@MartinNowak
Copy link
Contributor

There is some effort to get D support for version 3 into the official protocol buffers repo.
You should get in contact with Dragos Carp https://github.com/dcarp/protobuf.

@WebDrake
Copy link
Contributor

Has there been any progress on this?

@timotheecour
Copy link
Contributor

Timestamp doesn't seem supported

ref: https://developers.google.com/protocol-buffers/docs/proto3
=> unexpected label: Timestamp

@timotheecour
Copy link
Contributor

@msoucy
optional modifier shouldn't exist in proto3 (ie should be implicit), but dproto is being inconsistent:

syntax = "proto3";

message A{
  //Foo foo=1; // gives an error but should be accepted
  optional Foo foo=1;  // works but shouldn't
  string foo2=2;  // accepted, as it should
}

message Foo{
  int32 bar=1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants