Skip to content

Commit 9f3598d

Browse files
[Canvas] Fix falsey/null value bug for dropdown choices (elastic#69290) (elastic#70873)
* Fixed falsey/null value bug for dropdown choices * Filter only null and undefined values
1 parent 607ee02 commit 9f3598d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

x-pack/plugins/canvas/canvas_plugin_src/functions/common/dropdownControl.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,12 @@ export function dropdownControl(): ExpressionFunctionDefinition<
5252
fn: (input, { valueColumn, filterColumn, filterGroup }) => {
5353
let choices = [];
5454

55-
if (input.rows[0][valueColumn]) {
56-
choices = uniq(input.rows.map((row) => row[valueColumn])).sort();
55+
const filteredRows = input.rows.filter(
56+
(row) => row[valueColumn] !== null && row[valueColumn] !== undefined
57+
);
58+
59+
if (filteredRows.length > 0) {
60+
choices = uniq(filteredRows.map((row) => row[valueColumn])).sort();
5761
}
5862

5963
const column = filterColumn || valueColumn;

0 commit comments

Comments
 (0)