Fix go vet issues #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issues identified by the `go vet` command. - In `menus.go`, unkeyed struct literals for `menu.Item` have been converted to keyed literals to improve code clarity and maintainability. - In `main.go`, unreachable code following a `panic()` call in the `panicExit` function has been removed.
This commit addresses a wide range of issues identified by the `golangci-lint` command. The changes include: - Handling previously unchecked errors. - Removing deprecated `+build` tags and replacing them with `//go:build` directives. - Replacing deprecated function calls, including `rand.Seed`, `io/ioutil`, and `InspectContainer`. - Fixing ineffective assignments and break statements. - Correcting error string formatting. - Removing redundant assignments and break statements. - Simplifying string replacements. - Removing a significant amount of unused code, including functions, variables, and fields.
This commit adds the `LINTING.md` file, which contains a detailed code review and summary of the changes made to address the issues reported by `go vet` and `golangci-lint`.
This commit introduces the `ARCHITECTURE.md` file, which provides a detailed explanation of the ctop application's architecture and design. The document includes: - An overview of the application and its objectives. - A breakdown of the architecture and key design choices, including the connector interface, data model, and concurrency model. - A comprehensive list of command-line arguments with descriptions, types, and default values. - Examples of how to use the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.