Skip to content

Conversation

@k0d3r1s
Copy link

@k0d3r1s k0d3r1s commented Dec 4, 2025

Hi. Tried building against php master branch and this issue jumped out.
php UPGRADING.INTERNALS says: "The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed. Call zval_ptr_dtor_nogc() directly instead.".
So as this is purely removed alias, this seems to be a trivial fix

Call zval_ptr_dtor_nogc() directly instead
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.30%. Comparing base (712cc13) to head (bbf8786).
⚠️ Report is 86 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   73.88%   68.30%   -5.59%     
==========================================
  Files           6        7       +1     
  Lines        1191     1341     +150     
  Branches        0      245     +245     
==========================================
+ Hits          880      916      +36     
+ Misses        311      310       -1     
- Partials        0      115     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants