revise eslint settings

Author: gfx

.eslintrc.js

@@ -19,8 +19,11 @@ module.exports = {
     "no-useless-escape": "warn",
     "no-console": "warn",
     "valid-typeof": "warn", // "bigint" is not yet supported
+    "no-return-await": "error",
+    "prefer-const": "error",
+    "guard-for-in": "error",
 
-    "@typescript-eslint/no-unused-vars": ["warn", { argsIgnorePattern: "^_|^intl$" }],
+    "@typescript-eslint/no-unused-vars":"warn",
     "@typescript-eslint/array-type": ["error", "generic"],
     "@typescript-eslint/camelcase": "warn",
     "@typescript-eslint/class-name-casing": "warn", // to allow the initial underscore
@@ -29,6 +32,9 @@ module.exports = {
     "@typescript-eslint/prefer-includes": "warn",
     "@typescript-eslint/prefer-string-starts-ends-with": "warn",
     "@typescript-eslint/no-use-before-define": "warn",
+    "@typescript-eslint/restrict-plus-operands": "error",
+    "@typescript-eslint/await-thenable": "error",
+    "@typescript-eslint/no-for-in-array": "error",
 
     "@typescript-eslint/indent": "off",
     "@typescript-eslint/no-explicit-any": "off",

package.json

@@ -14,6 +14,7 @@
     "test:cover": "npx nyc mocha 'test/**/*.test.ts'",
     "lint": "eslint --ext .ts src test",
     "lint:fix": "eslint --fix --ext .ts src test && npm run format",
+    "lint:print-config": "eslint --print-config .eslintrc.js",
     "format": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
     "profile:encode": "rm -f isolate-*.log ; node --prof --require ts-node/register  -e 'require(\"./benchmark/profile-encode\")' && node --prof-process --preprocess -j isolate-*.log | npx flamebearer",
     "profile:decode": "rm -f isolate-*.log ; node --prof --require ts-node/register  -e 'require(\"./benchmark/profile-decode\")' && node --prof-process --preprocess -j isolate-*.log | npx flamebearer",

src/Decoder.ts

@@ -55,7 +55,7 @@ export class Decoder {
     return new RangeError(`Extra ${view.byteLength - pos} byte(s) found at buffer[${posToShow}]`);
   }
 
-  decodeOneSync() {
+  decodeOneSync(): unknown {
     const object = this.decodeSync();
     if (this.hasRemaining()) {
       throw this.createNoExtraBytesError(this.pos);

src/decodeAsync.ts

@@ -12,5 +12,5 @@ export async function decodeAsync(
   { extensionCodec }: DecodeAsyncOptions = {},
 ): Promise<unknown> {
   const decoder = new Decoder(extensionCodec);
-  return await decoder.decodeOneAsync(stream);
+  return decoder.decodeOneAsync(stream);
 }

test/msgpack-test-suite.test.ts

@@ -57,7 +57,7 @@ describe("msgpack-test-suite", () => {
   Exam.getExams(TEST_TYPES).forEach((exam) => {
     const types = exam.getTypes(TEST_TYPES);
     const first = types[0];
-    const title = first + ": " + exam.stringify(first);
+    const title = `${first}: ${exam.stringify(first)}`;
     it(`encodes ${title}`, () => {
       types.forEach((type) => {
         const value = exam.getValue(type);