Fix #296 with new compatibility options #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the date time is before Unix epoc and it has subsecond value, internal divrem operation returns negative remains and it causes exception. This commit add adjustment for this situation.
* Add ChangeLog entry. * Code formatting according to .editorconfig settings including member name. * Fix XML syntax error. * Add Unit test for all projects.
|
I just forgot to merge this and I come back github :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #296 for master (1.1) branch.
This PR also includes new compatibility options to improve 0.9.x compatibility for DateTime related types serialization, and some stability improvements for CI and release.