Skip to content

Graceful shutdown support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Leechael
Copy link

@Leechael Leechael commented Jun 9, 2013

I'm added some codes for graceful shutdown support, may be helpful. :P

@repeatedly
Copy link
Contributor

It is difficult problem.

If use msgpack-rpc-python as a stand alone server, then this code may be helpful.

But msgpack-rpc-python is a library.
In this case, library doesn't know an application requirement.
An application knows "this signal means", "How to handle this signal", but msgpack-rpc-python doesn't.

What do you think?

@Leechael
Copy link
Author

Hi @repeatedly , In my scenario, I'm run msgpack-rpc with Supervisord, and using msgpack-rpc added components to my main service. So when I upgrading my component, I'm using Supervisord send SIGHUP signal to msgpack-rpc server than restart it gracefully. When I have multiple components run base msgpack-rpc, this way added signal handling is the fast way and reduce codes for same job.

I'd like hear some advises from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants