use proper fallthrough annotations

Andre-ARM · trini · commit 26b2482f124b · 2025-04-08T16:23:51.000-06:00
In some cases in the generic code, we were already using switch/case
fallthrough annotations comments, though in a way which might not be
understood by most compilers.

Replace two non-standard /* no break */ comments with our fallthrough;
statement-like macro, to make this visible to the compiler.
Also use this macro in place of an /* Fall through */ comment, to be
more consistent.

Signed-off-by: Andre Przywara &lt;andre.przywara@arm.com&gt;
Reviewed-by: Tom Rini &lt;trini@konsulko.com&gt;
diff --git a/common/command.c b/common/command.c
@@ -484,7 +484,7 @@ int cmd_get_data_size(const char *arg, int default_size)
 		case 'q':
 			if (MEM_SUPPORT_64BIT_DATA)
 				return 8;
-			/* no break */
+			fallthrough;
 		default:
 			return CMD_DATA_SIZE_ERR;
 		}
diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
@@ -282,7 +282,7 @@ static int _vprintf(struct printf_info *info, const char *fmt, va_list va)
 					break;
 				}
 				islong = true;
-				/* no break */
+				fallthrough;
 			case 'x':
 				if (islong) {
 					num = va_arg(va, unsigned long);
diff --git a/net/net.c b/net/net.c
@@ -1559,7 +1559,7 @@ static int net_check_prereq(enum proto_t protocol)
 			puts("*** ERROR: `ipaddr' not set\n");
 			return 1;
 		}
-		/* Fall through */
+		fallthrough;
 
 #ifdef CONFIG_CMD_RARP
 	case RARP:

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,7 @@ int cmd_get_data_size(const char *arg, int default_size)`
`484`	`484`	`case 'q':`
`485`	`485`	`if (MEM_SUPPORT_64BIT_DATA)`
`486`	`486`	`return 8;`
`487`		`- /* no break */`
	`487`	`+ fallthrough;`
`488`	`488`	`default:`
`489`	`489`	`return CMD_DATA_SIZE_ERR;`
`490`	`490`	`}`
Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ static int _vprintf(struct printf_info info, const char fmt, va_list va)`
`282`	`282`	`break;`
`283`	`283`	`}`
`284`	`284`	`islong = true;`
`285`		`- /* no break */`
	`285`	`+ fallthrough;`
`286`	`286`	`case 'x':`
`287`	`287`	`if (islong) {`
`288`	`288`	`num = va_arg(va, unsigned long);`
Original file line number	Diff line number	Diff line change
`@@ -1559,7 +1559,7 @@ static int net_check_prereq(enum proto_t protocol)`
`1559`	`1559`	puts("*** ERROR: `ipaddr' not set\n");
`1560`	`1560`	`return 1;`
`1561`	`1561`	`}`
`1562`		`- /* Fall through */`
	`1562`	`+ fallthrough;`
`1563`	`1563`
`1564`	`1564`	`#ifdef CONFIG_CMD_RARP`
`1565`	`1565`	`case RARP:`