Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check #29

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix version check #29

wants to merge 5 commits into from

Conversation

thavlik
Copy link

@thavlik thavlik commented Dec 17, 2020

I am using pytorch 1.6.0+cu101, which excepts on your version check code. The simple fix is to remove the suffix.

Thank you!

@adhoc-research
Copy link

@msamogh this fixes an error which previously was preventing me from using the library. Please consider merging :)

@thavlik
Copy link
Author

thavlik commented Jan 24, 2021

I was lazy and made a few other commits, so this PR needs to be either accepted in full or manually merged. I have been using my fork of nonechucks in my rollouts for over a month now without issues. All of my setup scripts use pip install 'git+https://github.com/thavlik/nonechucks.git' so I personally don't have a need to see these changes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants