Repository navigation
git-hook enforcement silently dead: dangling pre-push symlink into deleted worktree; no pre-commit installed under explicit core.hooksPath #11598
Description
Activity
Closed — merged to Dev_new_gui via #11914 (squash 2c43eca). Fix: new idempotent, machine-portable scripts/install-git-hooks.sh installs REAL hook files (not worktree symlinks), normalizes bad absolute core.hooksPath, replaces dangling symlinks, and PRESERVES a pre-commit-framework-managed hook (warn+skip) so the full quality suite isn't clobbered; standalone pre-commit branch-guard is the fallback when the pre-commit binary isn't installed. Verified in throwaway temp repos: main/master commits blocked (exit 1), Dev_new_gui/issue-* allowed, idempotent re-run, framework hook preserved. Discoveries: none.
- added a commit that references this issue
on Aug 24, 2026 - added a commit that references this issue
on Sep 27, 2026
Discovered while fixing the Stop-hook permission error.
core.hooksPath=/home/martins/AutoBot-Ai/AutoBot-AI/.git/hooks(explicit, absolute — also violates machine portability). In that directory:pre-pushis a symlink to.worktrees/issue-5142-hooks/tools/git-hooks/pre-push— the worktree is long deleted, so the symlink dangles and pre-push protection silently never runs. There is NOpre-commitfile at all, so the documented protected-branch/worktree-only commit enforcement (CLAUDE_GIT.md) is not active either. Needs: an idempotent hook installer (likely fromscripts/hooks/templates) that installs real files (not worktree symlinks), plus verification that branch-guard actually blocks a main-tree commit. Related: #11581, #11593.