Fixups for string-pointer removal #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've changed their anchor pattern for inline comments. Signed-off-by: W. Trevor King <wking@tremily.us>
The maintainer position on this has shifted, with the sea change coming around [1]. [1]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-01-11-22.04.log.html#l-108 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
string-pointer-fixups
branch
from
85f8db8
to
4b23965
Compare
Catch up with 868e631 (Remove string pointers, 2017-01-12, opencontainers#653). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
string-pointer-fixups
branch
from
4b23965
to
c6c68c7
Compare
|
opencontainers#653 landed without this, so I've filed these changes as opencontainers#656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes I'm calling for in opencontainers#653.
85f8db8 should be squashed into your 868e631. Feel free to squash the other two commits or not as you see fit, although I'd like to have the meeting-log link in the final commit message for that change.