Skip to content

Commit 2dd08ca

Browse files
committed
Use SOC_LEDC_ macros to define LEDC constants instead
More reliable than checking checking chip models
1 parent a81c809 commit 2dd08ca

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/ledc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ mrb_mruby_esp32_ledc_gem_init(mrb_state* mrb)
168168
define_const(LEDC_LOW_SPEED_MODE);
169169
//
170170
// Only original ESP32 defines LEDC_HIGH_SPEED_MODE, second group with 8 more channels.
171-
#if defined(CONFIG_IDF_TARGET_ESP32)
171+
#ifdef SOC_LEDC_SUPPORT_HS_MODE
172172
define_const(LEDC_HIGH_SPEED_MODE);
173173
#endif
174174

@@ -183,7 +183,7 @@ mrb_mruby_esp32_ledc_gem_init(mrb_state* mrb)
183183
define_const(LEDC_CHANNEL_4);
184184
define_const(LEDC_CHANNEL_5);
185185
// Only original ESP32, S2 and S3 have 6,7.
186-
#if defined(CONFIG_IDF_TARGET_ESP32) || defined(CONFIG_IDF_TARGET_ESP32S2) || defined(CONFIG_IDF_TARGET_ESP32S3)
186+
#if SOC_LEDC_CHANNEL_NUM==8
187187
define_const(LEDC_CHANNEL_6);
188188
define_const(LEDC_CHANNEL_7);
189189
#endif
@@ -211,8 +211,8 @@ mrb_mruby_esp32_ledc_gem_init(mrb_state* mrb)
211211
define_const(LEDC_TIMER_12_BIT);
212212
define_const(LEDC_TIMER_13_BIT);
213213
define_const(LEDC_TIMER_14_BIT);
214-
// 15-bit+ timers available on original ESP32, C6 and H2.
215-
#if defined(CONFIG_IDF_TARGET_ESP32) || defined(CONFIG_IDF_TARGET_ESP32C6) || defined(CONFIG_IDF_TARGET_ESP32H2)
214+
// 15 to 20-bit timers available on original ESP32, C6 and H2.
215+
#if SOC_LEDC_TIMER_BIT_WIDTH==20
216216
define_const(LEDC_TIMER_15_BIT);
217217
define_const(LEDC_TIMER_16_BIT);
218218
define_const(LEDC_TIMER_17_BIT);

0 commit comments

Comments
 (0)