Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to specify the length in the settings.py array itself at which the dropdown will work #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added the ability to specify the length in the settings.py array itself at which the dropdown will work #14

wants to merge 2 commits into from

Conversation

NMelis
Copy link

@NMelis NMelis commented Aug 12, 2018

Added the ability to specify the length in the settings.py array itself at which the dropdown will work

@mrts
Copy link
Owner

mrts commented Oct 21, 2018 •
edited
Loading

This does not feel quite right... let it simmer a bit more. But many thanks for the proposal and your contribution!

@mrts
Copy link
Owner

mrts commented Sep 9, 2022 •
edited
Loading

@NMelis, I sincerely hope that it's okay to get back to this four years later! I really appreciate your contribution and want to include it, but I think the get_setting template tag is too general. Can you please add a template tag admin_listfilter_dropdown_threshold that fetches the threshold from settings and if it's missing, returns the default value? Can you please name the file admin_listfilter_dropdown_threshold.py instead of custom_tags.py? Can you please also document the setting?

@mrts mrts mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NMelis @mrts