Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Possibility to have orientation props. #572

Closed
2 tasks done
geoffreyLB opened this issue Nov 5, 2021 · 5 comments
Closed
2 tasks done

✨ Possibility to have orientation props. #572

geoffreyLB opened this issue Nov 5, 2021 · 5 comments

Comments

@geoffreyLB
Copy link

geoffreyLB commented Nov 5, 2021

What feature or enhancement are you suggesting?

I think it would be great to have as react-native-camera a props orientation to pass in takePhoto.
Actually if you have your app lock in portrait, you can't just turn your phone and take a photo in landscape mode.

Switched from react-native-camera to this repository and I have to admit this feature miss a lot.

Let me know what you think.

What Platforms whould this feature/enhancement affect?

iOS, Android

Alternatives/Workarounds

I used to unlock-portrait-mode on the app when taking picture and unfortunately the transition on IOS device is not smooth at all, the previous screen drools on camera screen.

Additional information

@mrousavy
Copy link
Owner

mrousavy commented Nov 8, 2021

Hi!
I don't really get what orientation should do, why do you need that feature? If you want to take a landscape picture, either rotate your phone to landscape (don't lock to portrait) or rotate the picture afterwards?

@jzxchiang1
Copy link

+1, this feature would be helpful.

Hi! I don't really get what orientation should do, why do you need that feature? If you want to take a landscape picture, either rotate your phone to landscape (don't lock to portrait) or rotate the picture afterwards?

Well, sometimes we have to lock to portrait if we don't want the UI to get rotated. For example, that's what the Camera app does on Android (instead of rotating the entire UI, it just rotates a couple of buttons). But even though the UI is locked, we still want to take a photo in landscape mode if the device is rotated.

@mrousavy
Copy link
Owner

mrousavy commented Jan 4, 2022

Okay that's interesting. This would be easy for takePhoto, although it comes with a performance penalty on Android. For Video Recordings, it's a bit more complicated. I can see how I can achieve it on iOS, but no idea how that would work for Android's CameraX Recorder class.

@mrousavy
Copy link
Owner

mrousavy commented Jan 4, 2022

Implemented in #715! Hope this works for you guys :) If you appreciate the work I do in my free time, please consider sponsoring me on GitHub, it would mean a lot to me. 🖤

@mrousavy
Copy link
Owner

Hey - I'm tracking Orientation in this feature request/issue now: #1891

Make sure to upvote or sponsor to support this feature, and leave a comment if you have any additional thoughts/ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants