Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Engine.IO Protocol v4: reverse ping/pong mechanism #858

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

HashJang
Copy link

No description provided.

@HashJang
Copy link
Author

for #835, but it is a broken change and cannot be ported to the version for socket.io v1/2
It may be better to add various branch for various version compatibility

@mrniko
Copy link
Owner

mrniko commented Sep 6, 2022

Thanks for contribution. Please correct conflicts with latest codebase.

@luoqiz
Copy link

luoqiz commented Sep 8, 2022

waiting ...

# Conflicts:
#	src/main/java/com/corundumstudio/socketio/handler/AuthorizeHandler.java
@HashJang
Copy link
Author

Thanks for contribution. Please correct conflicts with latest codebase.

resolved~

@mrniko mrniko merged commit e2452f4 into mrniko:master Sep 16, 2022
@mrniko
Copy link
Owner

mrniko commented Sep 16, 2022

Thank you!

osaka911 pushed a commit to osaka911/netty-socketio that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants