Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{a,b,c} no longer considered a dynamic pattern #347

Closed
amitdahan opened this issue Jan 9, 2022 · 1 comment · Fixed by #348
Closed

{a,b,c} no longer considered a dynamic pattern #347

amitdahan opened this issue Jan 9, 2022 · 1 comment · Fixed by #348
Assignees
@mrmlnc
Labels
Type: Bug
Milestone
3.2.10

Comments

@amitdahan
Copy link
Contributor

Bug Report

Starting with the newly released version 3.2.8 - {a,b,c} (sets bigger than 2) is no longer true for isDynamicPattern, while we only test for {a,b} (which still IS considered dynamic).

This broke exactly here:

https://github.com/mrmlnc/fast-glob/pull/344/files#diff-353cf32a130afd9d8b40a67a67f30b51434672caa8ab235726cbd0c82f65fc75R15

Expected behavior

isDynamicPattern('{a,b,c}') === true
@amitdahan amitdahan mentioned this issue Jan 9, 2022
Merged
@mrmlnc mrmlnc added this to the 3.2.10 milestone Jan 9, 2022
@mrmlnc mrmlnc self-assigned this Jan 9, 2022
@MurzNN
Copy link

MurzNN commented Jan 14, 2022

Seems this is not fixed, because I can reproduce this issue with 3.2.10 too, here is my bug report: #351

@SherfeyInv SherfeyInv mentioned this issue May 24, 2024
Merged
@rntvicente rntvicente mentioned this issue May 24, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrmlnc mrmlnc

Labels
Type: Bug
Projects
None yet
Milestone
3.2.10
Development

Successfully merging a pull request may close this issue.

Fix braces pattern to support more than 2 choices amitdahan/fast-glob
3 participants
@MurzNN @mrmlnc @amitdahan