Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching breaks with 3.2.0 or newer #273

Closed
danez opened this issue Jun 8, 2020 · 3 comments
Closed

Matching breaks with 3.2.0 or newer #273

danez opened this issue Jun 8, 2020 · 3 comments
Assignees

Comments

@danez
Copy link

danez commented Jun 8, 2020

Environment

  • OS Version: macOS 10.15.5
  • Node.js Version: 12.18.0

Actual behavior (3.2.2)

fast-glob([
  '/path/to/src/modules/*/actions/**/*.php',
  '!**/src/modules/go/**/*.php',
])
[]

Expected behavior (3.1.1)

fast-glob([
  '/path/to/src/modules/*/actions/**/*.php',
  '!**/src/modules/go/**/*.php',
])
[
/path/to/src/modules/A/actions/A.php",
"/path/to/src/modules/A/actions/B.php",
"/path/to/src/modules/A/actions/C.php",
"/path/to/src/modules/A/actions/D.php",
"/path/to/src/modules/A/actions/E.php",
"/path/to/src/modules/B/actions/sub/A.php",
 ... 2914 matches
]

Steps to reproduce

  1. See above

Code sample

fast-glob([
  '/path/to/src/modules/*/actions/**/*.php',
  '!**/src/modules/go/**/*.php',
])
@mrmlnc mrmlnc self-assigned this Jun 8, 2020
@mrmlnc
Copy link
Owner

mrmlnc commented Jun 8, 2020

Thank you for the detailed description of the issue 🎉

Based on the description, I think it's a duplicate for #266. I'll fix it soon.

@mrmlnc mrmlnc closed this as completed Jun 8, 2020
@mrmlnc
Copy link
Owner

mrmlnc commented Jun 16, 2020

Shipped with 3.2.3.

@danez
Copy link
Author

danez commented Jun 17, 2020

Thanks works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants