fast-glob@3.2.0 uses an outdated version of picomatch with Yarn

[anilanar]

Environment

• OS Version: MacOS
• Node.js Version: 12.14.0

There was a regression in https://github.com/dotansimha/graphql-code-generator and after investigating the issue, I've concluded that there's a regression in fast-glob@3.2.0.

You can see the original issue here, which has a reproduction in codesandbox: dotansimha/graphql-code-generator#3512

The problem:

fast-glob/src/utils/pattern.ts

Lines 106 to 118 in 1757299

	export function getPatternParts(pattern: Pattern, options: MicromatchOptions): Pattern[] {
	const info = micromatch.scan(pattern, {
	...options,
	parts: true
	});
	// See micromatch/picomatch#58 for more details
	if (info.parts.length === 0) {
	return [pattern];
	}
	return info.parts;
	}

With micromatch@4.0.2 (latest version), info doesn't seem to have a parts property.

[anilanar]

Could this be a further problem down the rabbit hole in micromatch -> picomatch?

[jonschlinkert]

@mrmlnc let me know if you need me to do something to fix this. I can push up a patch if you need me to and can give me guidance on what needs to be fixed, but I won't have much time to debug until Tuesday morning.

Or ping me if you want me to add you to the repo and npm -- we've collaborated a lot over the past couple of years, I'd be happy to add you.

[mrmlnc]

Additional case:

• An in-range update of fast-glob is breaking the build 🚨 TheNoim/fastify-loader#19

Looks like we got a combo.

Initial state:

fast-glob → micromatch@^4.0.2 → picomatch@^2.0.5

Something inside the graphql-code-generator also requires the picomatch version. But I can't see anywhere declaration with ~. It seems that yarn does not update transitive dependencies unnecessarily (npm do it — https://github.com/zaripych/node-op/pull/59/files).

And, yeap, yarn does not update transitive dependencies (1, 2).

To avoid this situation we need:

• Require picomatch@^2.2.1 inside micromatch. PR → here
• Require micromatch@4.x.x inside fast-glob.

[ivan-kleshnin]

Not sure if it's the same issue but fast-glob 3.2.0 doesn't work with simplest patterns (like a single asterisk) for me. Sorry for spamming but the library is broken at the moment.

[mrmlnc]

@ivan-kleshnin, please, file your issue into separated issue if you do not use yarn. I don't see any problems in addition described in this issue (for a limited number of yarn users with yarn.lock).

[mrmlnc]

I'm rolled back the fast-glob@3.2.0 version to fast-glob@3.1.1 in npm. Wait for the micromatch package release.

[mrmlnc]

Temporarily fixed on the side of this package.

Release:

https://github.com/mrmlnc/fast-glob/releases/tag/3.2.1

Issue:

#256