Skip to content

Commit 4ac73f4

Browse files
committed
Fix a possible heap corruption when no breakpoints are set
1 parent ad22697 commit 4ac73f4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/plugin.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ static bool cbMiniDump(int argc, char* argv[])
4444
// Disable all software breakpoints
4545
std::vector<duint> disabled_breakpoints;
4646
{
47-
BPMAP bplist;
47+
BPMAP bplist = {};
4848
DbgGetBpList(bp_normal, &bplist);
4949
for (int i = 0; i < bplist.count; i++)
5050
{
5151
const auto& bp = bplist.bp[i];
5252
if (bp.active && bp.enabled)
5353
{
5454
char cmd[256] = "";
55-
sprintf_s(cmd, "bd 0x%p", bp.addr);
55+
sprintf_s(cmd, "bd 0x%p", (void*)bp.addr);
5656
if (DbgCmdExecDirect(cmd))
5757
disabled_breakpoints.push_back(bp.addr);
5858
}
@@ -90,7 +90,7 @@ static bool cbMiniDump(int argc, char* argv[])
9090
for (auto addr : disabled_breakpoints)
9191
{
9292
char cmd[256] = "";
93-
sprintf_s(cmd, "be 0x%p", addr);
93+
sprintf_s(cmd, "be 0x%p", (void*)addr);
9494
DbgCmdExecDirect(cmd);
9595
}
9696

0 commit comments

Comments
 (0)