CapsuleGeometry: Use correct length property name in parameters.
#26405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify this.parameters.height to 'length' cuz it uses data.length in fromJSON(). this problem happens when you try pass a capsule's parameters to create another capsule using fromJSON()
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
changed the title
length property name in parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify this.parameters.height to 'length' cuz it uses data.length in fromJSON().
Description
this problem happens when you try passing a CapsuleGeometry.parameters object to create another capsule using fromJSON(), inside fromJSON(), the 2nd param - length will always be 'undefined' cuz there's no this key - 'length' in CapsuleGeometry.parameters