Skip to content

Fix some of the lint-addons warnings and errors #26388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix some of the lint-addons warnings and errors #26388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/jsm/loaders/FBXLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ class FBXTreeParser {

} else {

material = new MeshPhongMaterial( {
material = new MeshPhongMaterial( {
name: Loader.DEFAULT_MATERIAL_NAME,
color: 0xcccccc
} );
Expand Down
2 changes: 2 additions & 0 deletions examples/jsm/loaders/KTX2Loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,14 @@ class KTX2Loader extends Loader {

const texture = mipmaps[ 0 ];
texture.mipmaps = mipmaps.map( dt => {

return {
data: dt.source.data,
width: dt.source.data.width,
height: dt.source.data.height,
depth: dt.source.data.depth
};

} );
return texture;

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/LDrawLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ class LDrawParsedCache {
const text = await fileLoader.loadAsync( subobjectURL );
return text;

} catch {
} catch ( _ ) {
Copy link
Contributor

@LeviPesin LeviPesin Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add also Optional Catch Binding to the linter? It has appeared in the specification only in ES2019 but was supported everywhere for a long time.

Copy link
Contributor Author

@hybridherbst hybridherbst Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe do that in a follow-up PR? I'm unfortunately not familiar with configuring the linter (yet)

Copy link
Contributor

@LeviPesin LeviPesin Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with it too, actually 😅


continue;

Expand Down
6 changes: 3 additions & 3 deletions examples/jsm/loaders/NRRDLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@ class NRRDLoader extends Loader {

volume.inverseMatrix = new Matrix4();
volume.inverseMatrix.copy( volume.matrix ).invert();

volume.RASDimensions = [
Math.floor( volume.xLength * spacingX ),
Math.floor( volume.yLength * spacingY ),
Math.floor( volume.xLength * spacingX ),
Math.floor( volume.yLength * spacingY ),
Math.floor( volume.zLength * spacingZ )
];

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/PLYLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ class PLYLoader extends Loader {
// ascii section using \r\n as line endings
if ( hasCRNL === true ) i ++;

return { headerText: lines.join( '\r' ) + '\r', headerLength: i };
return { headerText: lines.join( '\r' ) + '\r', headerLength: i };

}

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/VRMLLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ class VRMLLoader extends Loader {

// if the appearance field is NULL or unspecified, lighting is off and the unlit object color is (0, 0, 0)

let material = new MeshBasicMaterial( {
let material = new MeshBasicMaterial( {
name: Loader.DEFAULT_MATERIAL_NAME,
color: 0x000000
} );
Expand Down
10 changes: 4 additions & 6 deletions examples/jsm/misc/Volume.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,20 +340,18 @@ class Volume {

}


let iLength, jLength;

if( ! this.segmentation ) {
if ( ! this.segmentation ) {

firstDirection.applyMatrix4( volume.inverseMatrix ).normalize();
secondDirection.applyMatrix4( volume.inverseMatrix ).normalize();
axisInIJK.applyMatrix4( volume.inverseMatrix ).normalize();

}

firstDirection.arglet = 'i';
secondDirection.arglet = 'j';
iLength = Math.floor( Math.abs( firstDirection.dot( dimensions ) ) );
jLength = Math.floor( Math.abs( secondDirection.dot( dimensions ) ) );
const iLength = Math.floor( Math.abs( firstDirection.dot( dimensions ) ) );
const jLength = Math.floor( Math.abs( secondDirection.dot( dimensions ) ) );
const planeWidth = Math.abs( iLength * firstSpacing );
const planeHeight = Math.abs( jLength * secondSpacing );

Expand Down
4 changes: 2 additions & 2 deletions examples/jsm/nodes/geometry/RangeNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class RangeNode extends Node {

if ( object.isInstancedMesh === true ) {

let minValue = this.minNode.value;
let maxValue = this.maxNode.value;
const minValue = this.minNode.value;
const maxValue = this.maxNode.value;

const minLength = builder.getTypeLength( getValueType( minValue ) );
const maxLength = builder.getTypeLength( getValueType( maxValue ) );
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/nodes/shadernode/ShaderNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ const safeGetNodeType = ( node ) => {

return node.getNodeType();

} catch {
} catch ( _ ) {

return undefined;

Expand Down
1 change: 1 addition & 0 deletions examples/jsm/renderers/webgpu/utils/WebGPUAttributeUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class WebGPUAttributeUtils {
buffer.unmap();

bufferData.buffer = buffer;

}

}
Expand Down