CubeTextureLoader: Return sRGB textures by default. #26162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23614
Description
When working at the sRGB migration, I've noticed that the examples use
CubeTextureLoaderto load always sRGB textures. Compared toTextureLoader, you usually do not useCubeTextureLoaderto load non-color data like normal, roughness or ao maps. Even for HDR texturesthree.jsoffers specific loaders.Because of this and because sRGB output is the default since
r152, I think it's safe to change the color space of the loaded cube texture toSRGBColorSpace.