Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 29, 2023

Related issue: #23614

Description

When working at the sRGB migration, I've noticed that the examples use CubeTextureLoader to load always sRGB textures. Compared to TextureLoader, you usually do not use CubeTextureLoader to load non-color data like normal, roughness or ao maps. Even for HDR textures three.js offers specific loaders.

Because of this and because sRGB output is the default since r152, I think it's safe to change the color space of the loaded cube texture to SRGBColorSpace.

@Mugen87 Mugen87 marked this pull request as ready for review May 29, 2023 08:05
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
642.7 kB (159.1 kB) 642.8 kB (159.1 kB) +22 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
432.9 kB (104.8 kB) 432.9 kB (104.8 kB) +0 B

@mrdoob mrdoob requested a review from donmccurdy May 29, 2023 10:16
@sunag
Copy link
Collaborator

sunag commented May 29, 2023

I made these changes in the WebGPU version as well here #26152
( I had the same problem )

Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants