Tests: Update Unit Test Readme #25453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unit test readme to reflect changes since #25380 Avoid building the library and flagging the files as changed (tests run off source) Add notes to help people running unit tests. ColorManagement.enabled is false by default. Tune logging so only genuine test failure messages are displayed.
Minimize the console messages captured.
LeviPesin
reviewed
Feb 7, 2023
mrdoob
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Update CompressedArrayTexture.tests.js Image property notes * Update CompressedTexture.tests.js Image property notes * Update CompressedArrayTexture.tests.js CompressedArrayTexture extends from CompressedTexture * Update ColorManagement.tests.js As pointed out in: #25453 (comment) * Update WebGL1Renderer.tests.js Can instantiate a WebGL1Renderer. * Update WebGLRenderer.tests.js * Update WebGL3DRenderTarget.tests.js Can instantiate a WebGL3DRenderTarget. * Update WebGLArrayRenderTarget.tests.js Can instantiate a WebGLArrayRenderTarget. * Update WebGLCubeRenderTarget.tests.js Can instantiate a WebGLCubeRenderTarget. * Update WebGLMultipleRenderTargets.tests.js Can instantiate a WebGLMultipleRenderTargets. * Update Fog.tests.js Can instantiate a Fog. Can instantiate a Fog with color. Can instantiate a Fog with color, near, far. * Update FogExp2.tests.js Can instantiate a FogExp2. Can instantiate a FogExp2 with color. Can instantiate a FogExp2 with color, density.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue :#25380
Description
Update unit test readme to reflect changes since #25380
Avoid building the library and flagging the files as changed (tests run off source)
Add notes to help people running unit tests.
ColorManagement.enabled is false by default. #24940
Tune logging so only test failure messages are displayed. 581c70b