Added zooming to cursor position in OrbitControls #24983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hogonal to the camera's up direction. Fixed calculating mouse position when canvas has margin or window is scrolled. Added 'maxTargetDistanceFromOrigin' parameter.
…ment has position relative.
|
Is there anything hindering this from being merged? Do you need any help? This would be such a great addition! |
GitHubDragonFly
referenced
this pull request
in GitHubDragonFly/GitHubDragonFly.github.io
Apr 7, 2023
- Add `ZoomToCursor` functionality as per `https://github.com/mrdoob/three.js/pull/24983`
|
What's going on with this? Would be so nice to have |
Collaborator
|
Thanks for your effort but #26165 has been merged instead. It would be great if you could use your expertise in this topic to have a closer look at the version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #17145
Proposing solution for zooming to mouse cursor/mobile touch pinch position in OrbitControls.
I know about #17145, but it seems to have some problems and limitations, don't know why it is still not implemented.
Working both for PerspectiveCamera and OrthographicCamera.
Working for both OrbitControls and MapControls.
Working both for mouse and touch events.
Working with and withount damping enabled.
No problem with division by 0.
No need to limit maxPolarAngle to Math.PI / 3
To enable zooming to cursor: controls.enableZoomToCursor = true, default is false.