ColladaExporter: Convert vertex, material colors to sRGB before export #23400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
Owner
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
mrdoob#23400) * ColladaExporter: Convert vertex, material colors to sRGB before export * convert specular color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23283
Description
Converts material colors (diffuse, emissive, specular color) and vertex colors to sRGB before exporting as a Collada file. It looks like vertex color export wasn't actually working correctly so this fixes that up, too, by correctly declaring vertex color accessors as R, G, B, and always writing colors as float values.
Tested by exporting the vertex-colored teapot from the exporter and loading it in the Collada loader example. Relatedly the ColladaLoader doesn't looks like it actually sets material.vertexColors = true anywhere so that needs to be set manually on load to test.