ColladaLoader regression with unit conversion

[eirikurn]

Revision
Latest dev - f1d6fc3

Description
Pull request #3079 caused a nasty head-ache for me.

It applies colladaUnit to each Object3D's scale recursively, making non top-level meshes quickly disappear from view for inch-based models.

I guess it needs to be a bit smarter. In the least only apply to some root node.

[mrdoob]

Ping @jihoonl.

[jihoonl]

@eirikurn

I pushed patched version in my repo. Can you check if it works for you?
jihoonl@6e5a024

[eirikurn]

I haven't had a chance to test it yet, but from looking at the commit, I have these comments.

It doesn't match the indentation (spaces instead of tabs). And I think multiplying the position of the scene isn't necessary, since it's always 0,0,0.

[psychok7]

i can confirm the fix. I works now and before it didnt

[jihoonl]

Well.. I will pull request soon with fixing indentation and removing position scaling.

[jihoonl]

Hm.. I found that @mrdoob already patched it.

9f1035b

[mrdoob]

I didn't do this though:

removing position scaling.

[mrdoob]

Done. Thanks!