Skip to content

Commit 5370b40

Browse files
committed
Revert "fix possible overrideMaterial material with .wireframe and cleanup"
This reverts commit 7dcd85e.
1 parent 7dcd85e commit 5370b40

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

examples/jsm/renderers/webgpu/WebGPURenderPipeline.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ class WebGPURenderPipeline {
2424

2525
}
2626

27-
init( cacheKey, stageVertex, stageFragment, renderObject, nodeBuilder ) {
27+
init( cacheKey, stageVertex, stageFragment, object, nodeBuilder ) {
2828

29-
const { object, material, geometry } = renderObject;
29+
const { material, geometry } = object;
3030

3131
// determine shader attributes
3232

@@ -84,7 +84,7 @@ class WebGPURenderPipeline {
8484

8585
//
8686

87-
const primitiveState = this._getPrimitiveState( object, geometry, material );
87+
const primitiveState = this._getPrimitiveState( object, material );
8888
const colorWriteMask = this._getColorWriteMask( material );
8989
const depthCompare = this._getDepthCompare( material );
9090
const colorFormat = this._utils.getCurrentColorFormat();
@@ -425,14 +425,15 @@ class WebGPURenderPipeline {
425425

426426
}
427427

428-
_getPrimitiveState( object, geometry, material ) {
428+
_getPrimitiveState( object, material ) {
429429

430430
const descriptor = {};
431431

432-
descriptor.topology = this._utils.getPrimitiveTopology( object, material );
432+
descriptor.topology = this._utils.getPrimitiveTopology( object );
433433

434434
if ( object.isLine === true && object.isLineSegments !== true ) {
435435

436+
const geometry = object.geometry;
436437
const count = ( geometry.index ) ? geometry.index.count : geometry.attributes.position.count;
437438
descriptor.stripIndexFormat = ( count > 65535 ) ? GPUIndexFormat.Uint32 : GPUIndexFormat.Uint16; // define data type for primitive restart value
438439

examples/jsm/renderers/webgpu/WebGPURenderPipelines.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class WebGPURenderPipelines {
6060

6161
// determine render pipeline
6262

63-
currentPipeline = this._acquirePipeline( stageVertex, stageFragment, renderObject );
63+
currentPipeline = this._acquirePipeline( stageVertex, stageFragment, renderObject.object, nodeBuilder );
6464
cache.currentPipeline = currentPipeline;
6565

6666
// keep track of all used times
@@ -92,14 +92,14 @@ class WebGPURenderPipelines {
9292

9393
}
9494

95-
_acquirePipeline( stageVertex, stageFragment, renderObject ) {
95+
_acquirePipeline( stageVertex, stageFragment, object, nodeBuilder ) {
9696

9797
let pipeline;
9898
const pipelines = this.pipelines;
9999

100100
// check for existing pipeline
101101

102-
const cacheKey = this._computeCacheKey( stageVertex, stageFragment, renderObject );
102+
const cacheKey = this._computeCacheKey( stageVertex, stageFragment, object );
103103

104104
for ( let i = 0, il = pipelines.length; i < il; i ++ ) {
105105

@@ -117,7 +117,7 @@ class WebGPURenderPipelines {
117117
if ( pipeline === undefined ) {
118118

119119
pipeline = new WebGPURenderPipeline( this.device, this.utils );
120-
pipeline.init( cacheKey, stageVertex, stageFragment, renderObject, this.nodes.get( renderObject ) );
120+
pipeline.init( cacheKey, stageVertex, stageFragment, object, nodeBuilder );
121121

122122
pipelines.push( pipeline );
123123

@@ -127,9 +127,9 @@ class WebGPURenderPipelines {
127127

128128
}
129129

130-
_computeCacheKey( stageVertex, stageFragment, renderObject ) {
130+
_computeCacheKey( stageVertex, stageFragment, object ) {
131131

132-
const { object, material } = renderObject;
132+
const material = object.material;
133133
const utils = this.utils;
134134

135135
const parameters = [
@@ -145,7 +145,7 @@ class WebGPURenderPipelines {
145145
material.side,
146146
utils.getSampleCount(),
147147
utils.getCurrentEncoding(), utils.getCurrentColorFormat(), utils.getCurrentDepthStencilFormat(),
148-
utils.getPrimitiveTopology( object, material )
148+
utils.getPrimitiveTopology( object )
149149
];
150150

151151
return parameters.join();

examples/jsm/renderers/webgpu/WebGPUUtils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ class WebGPUUtils {
6161

6262
}
6363

64-
getPrimitiveTopology( object, material ) {
64+
getPrimitiveTopology( object ) {
6565

6666
if ( object.isPoints ) return GPUPrimitiveTopology.PointList;
67-
else if ( object.isLineSegments || ( object.isMesh && material.wireframe === true ) ) return GPUPrimitiveTopology.LineList;
67+
else if ( object.isLineSegments || ( object.isMesh && object.material.wireframe === true ) ) return GPUPrimitiveTopology.LineList;
6868
else if ( object.isLine ) return GPUPrimitiveTopology.LineStrip;
6969
else if ( object.isMesh ) return GPUPrimitiveTopology.TriangleList;
7070

0 commit comments

Comments
 (0)