Editor: More let/const usage. (#23398)

Author: Mugen87

editor/js/Config.js

@@ -1,8 +1,8 @@
 function Config() {
 
-	var name = 'threejs-editor';
+	const name = 'threejs-editor';
 
-	var storage = {
+	const storage = {
 		'language': 'en',
 
 		'autosave': true,
@@ -33,9 +33,9 @@ function Config() {
 
 	} else {
 
-		var data = JSON.parse( window.localStorage[ name ] );
+		const data = JSON.parse( window.localStorage[ name ] );
 
-		for ( var key in data ) {
+		for ( const key in data ) {
 
 			storage[ key ] = data[ key ];
 
@@ -53,7 +53,7 @@ function Config() {
 
 		setKey: function () { // key, value, key, value ...
 
-			for ( var i = 0, l = arguments.length; i < l; i += 2 ) {
+			for ( let i = 0, l = arguments.length; i < l; i += 2 ) {
 
 				storage[ arguments[ i ] ] = arguments[ i + 1 ];
 

editor/js/History.js

@@ -14,7 +14,7 @@ function History( editor ) {
 
 	// signals
 
-	var scope = this;
+	const scope = this;
 
 	this.editor.signals.startPlayer.add( function () {
 
@@ -34,10 +34,10 @@ History.prototype = {
 
 	execute: function ( cmd, optionalName ) {
 
-		var lastCmd = this.undos[ this.undos.length - 1 ];
-		var timeDifference = new Date().getTime() - this.lastCmdTime.getTime();
+		const lastCmd = this.undos[ this.undos.length - 1 ];
+		const timeDifference = new Date().getTime() - this.lastCmdTime.getTime();
 
-		var isUpdatableCmd = lastCmd &&
+		const isUpdatableCmd = lastCmd &&
 			lastCmd.updatable &&
 			cmd.updatable &&
 			lastCmd.object === cmd.object &&
@@ -94,7 +94,7 @@ History.prototype = {
 
 		}
 
-		var cmd = undefined;
+		let cmd = undefined;
 
 		if ( this.undos.length > 0 ) {
 
@@ -129,7 +129,7 @@ History.prototype = {
 
 		}
 
-		var cmd = undefined;
+		let cmd = undefined;
 
 		if ( this.redos.length > 0 ) {
 
@@ -157,7 +157,7 @@ History.prototype = {
 
 	toJSON: function () {
 
-		var history = {};
+		const history = {};
 		history.undos = [];
 		history.redos = [];
 
@@ -169,7 +169,7 @@ History.prototype = {
 
 		// Append Undos to History
 
-		for ( var i = 0; i < this.undos.length; i ++ ) {
+		for ( let i = 0; i < this.undos.length; i ++ ) {
 
 			if ( this.undos[ i ].hasOwnProperty( 'json' ) ) {
 
@@ -181,7 +181,7 @@ History.prototype = {
 
 		// Append Redos to History
 
-		for ( var i = 0; i < this.redos.length; i ++ ) {
+		for ( let i = 0; i < this.redos.length; i ++ ) {
 
 			if ( this.redos[ i ].hasOwnProperty( 'json' ) ) {
 
@@ -199,10 +199,10 @@ History.prototype = {
 
 		if ( json === undefined ) return;
 
-		for ( var i = 0; i < json.undos.length; i ++ ) {
+		for ( let i = 0; i < json.undos.length; i ++ ) {
 
-			var cmdJSON = json.undos[ i ];
-			var cmd = new Commands[ cmdJSON.type ]( this.editor ); // creates a new object of type "json.type"
+			const cmdJSON = json.undos[ i ];
+			const cmd = new Commands[ cmdJSON.type ]( this.editor ); // creates a new object of type "json.type"
 			cmd.json = cmdJSON;
 			cmd.id = cmdJSON.id;
 			cmd.name = cmdJSON.name;
@@ -211,10 +211,10 @@ History.prototype = {
 
 		}
 
-		for ( var i = 0; i < json.redos.length; i ++ ) {
+		for ( let i = 0; i < json.redos.length; i ++ ) {
 
-			var cmdJSON = json.redos[ i ];
-			var cmd = new Commands[ cmdJSON.type ]( this.editor ); // creates a new object of type "json.type"
+			const cmdJSON = json.redos[ i ];
+			const cmd = new Commands[ cmdJSON.type ]( this.editor ); // creates a new object of type "json.type"
 			cmd.json = cmdJSON;
 			cmd.id = cmdJSON.id;
 			cmd.name = cmdJSON.name;
@@ -250,7 +250,7 @@ History.prototype = {
 		this.editor.signals.sceneGraphChanged.active = false;
 		this.editor.signals.historyChanged.active = false;
 
-		var cmd = this.undos.length > 0 ? this.undos[ this.undos.length - 1 ] : undefined;	// next cmd to pop
+		let cmd = this.undos.length > 0 ? this.undos[ this.undos.length - 1 ] : undefined;	// next cmd to pop
 
 		if ( cmd === undefined || id > cmd.id ) {
 
@@ -297,7 +297,7 @@ History.prototype = {
 		this.editor.signals.sceneGraphChanged.active = false;
 		this.editor.signals.historyChanged.active = false;
 
-		var cmd = this.redo();
+		let cmd = this.redo();
 		while ( cmd !== undefined ) {
 
 			if ( ! cmd.hasOwnProperty( 'json' ) ) {

editor/js/LoaderUtils.js

@@ -1,12 +1,12 @@
-var LoaderUtils = {
+const LoaderUtils = {
 
 	createFilesMap: function ( files ) {
 
-		var map = {};
+		const map = {};
 
-		for ( var i = 0; i < files.length; i ++ ) {
+		for ( let i = 0; i < files.length; i ++ ) {
 
-			var file = files[ i ];
+			const file = files[ i ];
 			map[ file.name ] = file;
 
 		}
@@ -19,11 +19,11 @@ var LoaderUtils = {
 
 		// TOFIX: setURLModifier() breaks when the file being loaded is not in root
 
-		var itemsCount = 0;
-		var itemsTotal = 0;
+		let itemsCount = 0;
+		let itemsTotal = 0;
 
-		var files = [];
-		var filesMap = {};
+		const files = [];
+		const filesMap = {};
 
 		function onEntryHandled() {
 
@@ -41,10 +41,10 @@ var LoaderUtils = {
 
 			if ( entry.isDirectory ) {
 
-				var reader = entry.createReader();
+				const reader = entry.createReader();
 				reader.readEntries( function ( entries ) {
 
-					for ( var i = 0; i < entries.length; i ++ ) {
+					for ( let i = 0; i < entries.length; i ++ ) {
 
 						handleEntry( entries[ i ] );
 
@@ -71,9 +71,9 @@ var LoaderUtils = {
 
 		}
 
-		for ( var i = 0; i < items.length; i ++ ) {
+		for ( let i = 0; i < items.length; i ++ ) {
 
-			var item = items[ i ];
+			const item = items[ i ];
 
 			if ( item.kind === 'file' ) {