A stab at the dark to avoid "test did not finish before its parent"

Author: DirtyHairy

test/node/socks.ts

@@ -138,7 +138,7 @@ class MockServer5 {
 	}
 }
 
-describe('SOCKS layer', { timeout: 1000 }, () => {
+describe('SOCKS layer', { timeout: 1000 }, async () => {
 	let server5!: MockServer5
 	let server4: Server | undefined
 
@@ -151,7 +151,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		server4?.close()
 	})
 
-	it('should resolve hostnames locally for socks5', async () => {
+	await it('should resolve hostnames locally for socks5', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -181,7 +181,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(server5.destinationPort(), 1883)
 	})
 
-	it('should resolve hostnames remotely for socks5h', async () => {
+	await it('should resolve hostnames remotely for socks5h', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -210,7 +210,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(server5.destinationPort(), 1883)
 	})
 
-	it('errors during name resolution should be emitted on stream', async () => {
+	await it('errors during name resolution should be emitted on stream', async () => {
 		const ERROR = new Error()
 
 		const lookup = mock.fn((address) => Promise.reject(ERROR))
@@ -226,7 +226,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(error, ERROR)
 	})
 
-	it('errors during SOCKS connect should be emitted on stream', async () => {
+	await it('errors during SOCKS connect should be emitted on stream', async () => {
 		const port = await server5.start()
 		server5.responseID = Buffer.from([0x00, 0x00])
 
@@ -252,7 +252,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert(err instanceof Error)
 	})
 
-	it('data flows through the stream after SOCKS has connected', async () => {
+	await it('data flows through the stream after SOCKS has connected', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -290,7 +290,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(response, 'ping pong')
 	})
 
-	it('data written to the stream is buffered until SOCKS has connected', async () => {
+	await it('data written to the stream is buffered until SOCKS has connected', async () => {
 		const port = await server5.start()
 
 		let startNameResolution!: () => undefined
@@ -336,7 +336,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(response, 'ping pong')
 	})
 
-	it('closing the stream closes the connection', async () => {
+	await it('closing the stream closes the connection', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -361,7 +361,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		})
 	})
 
-	it('closing the connection closes the stream', async () => {
+	await it('closing the connection closes the stream', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -385,7 +385,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		})
 	})
 
-	it('resetting the connection errors the stream', async () => {
+	await it('resetting the connection errors the stream', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -411,7 +411,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert(error instanceof Error)
 	})
 
-	it('an invalid protocol errors the stream', async () => {
+	await it('an invalid protocol errors the stream', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -429,7 +429,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert(error instanceof Error)
 	})
 
-	it('an invalid URL errors the stream', async () => {
+	await it('an invalid URL errors the stream', async () => {
 		const port = await server5.start()
 
 		const lookup = mock.fn((_: string) =>
@@ -447,7 +447,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert(error instanceof Error)
 	})
 
-	it('should resolve hostnames locally for socks4', async () => {
+	await it('should resolve hostnames locally for socks4', async () => {
 		let onConnect!: (socket: Socket) => void
 		const connect = new Promise<Socket>((r) => {
 			onConnect = mock.fn((socket: Socket) => {
@@ -487,7 +487,7 @@ describe('SOCKS layer', { timeout: 1000 }, () => {
 		assert.strictEqual(lookup.mock.calls[0].arguments[0], 'foo.bar')
 	})
 
-	it('should resolve hostnames remotely for socks4a', async () => {
+	await it('should resolve hostnames remotely for socks4a', async () => {
 		let onConnect!: (socket: Socket) => void
 		const connect = new Promise<Socket>((r) => {
 			onConnect = mock.fn((socket: Socket) => {