vd_lavc: don't hardware decode VC-1 by default #15737
Conversation
|
Download the artifacts for this pull request: |
|
This supersedes that. |
|
The "and new AMD GPUs don't support it all." part should go from the commit message as it's not relevant. |
|
Redone the commit message instead and explained how it's relevant. |
|
Works just fine on windows, except for seeking, when this happens the image falls apart on windows that on Linux usually causes green screen, I think this is some easy ffmpeg bug probably this one: #8515 (try reverting FFmpeg/FFmpeg@701e8b4)
|
No. This is still wrong. We do not optimize for startup time by changing |
VC-1 with nvdec shows a green screen, and users may not understand that it is caused by hwdec and that disabling it is the fix. Also there is no need to hardware decode VC-1 videos since nobody produces 4k VC-1 videos. Just remove it from the default hwdec-codecs, it is not worth implementing a system to guess whether it will work depending on the GPU. Fixes mpv-player#15715.
|
Issue with VC-1 decoging has been fixed in vaapi frontend https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33221 It also works fine on Windows as reported by ValeZAA. So the only remaining issue is with proprietary NVIDIA drivers on Linux. (probably the fix is similar to vaapi one, but would need to be done by NVIDIA obviously) |
vd_lavc: don't hardware decode VC-1 by default
VC-1 with nvdec shows a green screen, and users may not understand that it is caused by hwdec and that disabling it is the fix. It can break displaying videos on vaapi too (https://gitlab.freedesktop.org/mesa/mesa/-/issues/12525).
Also new AMD GPUs don't support hardware decoding VC-1 at all (https://en.wikipedia.org/wiki/Video_Core_Next). This slows down startup time if hardware decoding is attempted anyway, especially with --hwdec=auto.
Also there is no need to hardware decode VC-1 videos since nobody produces 4k VC-1 videos.
Just remove it from the default hwdec-codecs, it is not worth implementing a system to guess whether it will work depending on the GPU.
Fixes #15715.
(Github doesn't let me ropen #12407)