Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Migrate Youtube-DL to yt-dlp #8665

Closed
seniorm0ment opened this issue Mar 19, 2021 · 10 comments
Closed

[Feature Request] Migrate Youtube-DL to yt-dlp #8665

seniorm0ment opened this issue Mar 19, 2021 · 10 comments

Comments

@seniorm0ment
Copy link

Suggesting moving from Youtube-DL to yt-dlp
https://github.com/yt-dlp/yt-dlp

yt-dlp is a fork of Youtube-DLC (https://github.com/blackjack4494/yt-dlc - inactive), which is a fork of Youtube-DL. It brings a bit of a faster feature development, as well as actively listening to the community, where youtube-dl has not been so amazing in that aspect. It comes with some new features as well.

@CounterPillow
Copy link
Contributor

if the json dump invocation stayed the same don't need to move from anything to anything, it can just look for either of the two.

@Dudemanguy
Copy link
Member

Dudemanguy commented Mar 19, 2021

The youtube-dl hook is just a lua script. You can already set a custom path for whatever executable you want so there's no need for us to do anything. See the ytdl_path option in the manual.

@seniorm0ment
Copy link
Author

Thank you for clarifying. Sorry for the bother.

@avahe-kellenberger
Copy link

Is this not available as an option in mpv.conf? I'd prefer to not have to pass a command line flag every time.

@JohnDDuncanIII
Copy link

@avahe-kellenberger

  • ~/.config/mpv.conf

script-opts=ytdl_hook-ytdl_path="/opt/bin/yt-dlp"

then you can run a test with mpv -v <youtube_uri> to double check that it's using yt-dlp over youtube-dl

[ytdl_hook] full hook 
[ytdl_hook] found youtube-dl at: /opt/bin/yt-dlp 
[ytdl_hook] youtube-dl succeeded! 
[ytdl_hook] format selection: youtube-dl (separate) 

#8264 (comment)

@avih
Copy link
Member

avih commented Sep 9, 2021

script-opts=ytdl_hook-ytdl_path="/opt/bin/yt-dlp"

You probably want this instead:

script-opts-add=ytdl_hook-ytdl_path="/opt/bin/yt-dlp"

Note the additional -add, because if you don't use it, it will wipe any prior script-opts which were set at mpv.conf, but with script-opts-add=... it will add this value instead of wiping all prior values.

@avahe-kellenberger
Copy link

Thanks!

@sebma
Copy link

sebma commented Oct 6, 2021

The youtube-dl hook is just a lua script. You can already set a custom path for whatever executable you want so there's no need for us to do anything. See the ytdl_path option in the manual.

@Dudemanguy Strange, I see no ytdl_path option in the manual of mpv v0.32 :

$ man mpv | grep ytdl_path
$

Was this option introduced later ?

@Dudemanguy
Copy link
Member

Was this option introduced later ?

Yes, 0.32 is too old.

@sebma
Copy link

sebma commented Jun 8, 2022

@Dudemanguy

Was this option introduced later ?

Yes, 0.32 is too old.

It seems the ytdl_path of the ytdl_hook was introduced with mpv v0.33.0 :

$ git log v0.32.0..v0.33.0 | grep ytdl_path
    ytdl_hook: if ytdl not found in config dirs, use ytdl_path as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants