fix dbscan waitgroup panic when multiple workers are used #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I hope this message finds you well.
I'm raising this PR to fix negative wait group value when DBSCAN is utilising multiple threads.
Issue:
The division used to calculate c.f takes the floor of the integer value, which may result in the "nearest" function creating more rangeJobs than the number of workers. Consequently, this causes more calls to WaitGroup.Done than WaitGroup.Add, leading to a negative wait group value.
Solution:
Modify the calculation to use the ceiling of the integer value for c.f.
Thank you for your time.