Skip to content

Fixes for code check #988

Open
Open
@wgropp

Description

@wgropp

Problem

A few problems with the code checker were identified during the RC process.

Proposal

Fix the code checker (mpichk). The specific issues are:

  1. Add option to produce list of skipped code, so that it can be reviewed (there's been some errors found in skipped sections) Deferred.

  2. In mpichk.in, update to allow the lstlisting options caption and label

  3. Fix Unmatched ( in regex; marked by <-- HERE in m/([^{]){([^(])(
    <-- HERE (.)/ at ./mpicompilechk/mpichk line 542, line 1501.
    Relevant code is
    $es = substr($echars,0,1);
    $ee = substr($echars,1,1);
    while (/([^$es]
    )$es([^$ee])$ee(.)/) {

    This probably means a $ee contains an unescaped "(" character.
    Consider using quotemeta($es) and $ee

  4. p815. Add %%ERRONEOUS as mpichk option and use in this example. That could replace or augment the message option. Deferred

Changes to the Text

None

Impact on Implementations

None

Impact on Users

Better checks on the examples ensure a better document.

References and Pull Requests

See PR mpi-forum/mpi-standard/pull/1118, which addresses the issues not marked "Deferred"

Metadata

Metadata

Assignees

No one assigned

    Labels

    editor changeChanges to be made by the document editormpi-5.0For inclusion in the MPI 5.0 standardscheduled no-no voteNo-No vote is scheduled for the next meetingscheduled readingReading is scheduled for the next meeting

    Type

    No type

    Projects

    Status

    In Progress

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions