Fixing evaluation corner case and label

Author: sarrubia

splitio/clients.py

@@ -178,15 +178,15 @@ def _get_treatment_for_split(self, split, matching_key, bucketing_key, attribute
         roll_out = False
         for condition in split.conditions:
             if (not roll_out and
-                condition.condition_type == ConditionType.ROLLOUT):
+                    condition.condition_type == ConditionType.ROLLOUT):
                 if split.traffic_allocation < 100:
                     bucket = self.get_splitter().get_bucket(
                         bucketing_key,
                         split.traffic_allocation_seed,
                         split.algo
                     )
                     if bucket >= split.traffic_allocation:
-                        return split.default_treatment, condition.label
+                        return split.default_treatment, Label.NOT_IN_SPLIT
                 roll_out = True
 
             if condition.matcher.match(matching_key, attributes=attributes):

splitio/impressions.py

@@ -56,6 +56,11 @@ class Label(object):
     #Label: split not found
     SPLIT_NOT_FOUND = 'rules not found'
 
+    #Condition: Traffic allocation failed
+    #Treatment: Default Treatment
+    #Label: not in split
+    NOT_IN_SPLIT = 'not in split'
+
     # Condition: There was an exception
     # Treatment: control
     # Label: exception

splitio/splits.py

@@ -73,7 +73,12 @@ def __init__(self, name, seed, killed, default_treatment, traffic_type_name,
         self._status = status
         self._change_number = change_number
         self._conditions = conditions if conditions is not None else []
-        self._traffic_allocation = traffic_allocation if traffic_allocation else 100
+
+        if traffic_allocation >= 0 and traffic_allocation <= 100:
+            self._traffic_allocation = traffic_allocation
+        else:
+            self._traffic_allocation = 100
+
         self._traffic_allocation_seed = traffic_allocation_seed
         try:
             self._algo = HashAlgorithm(algo)