Merge pull request splitio#49 from splitio/hotfix-remove-stopped

Removed stopped on post impressions

Author: sarrubia

splitio/impressions.py

@@ -304,8 +304,6 @@ def _notify_eviction(self, feature_name, feature_impressions):
     def _timer_refresh(self):
         """Responsible for setting the periodic calls to _update_impressions using a Timer thread.
         """
-        if self._stopped:
-            return
 
         try:
             self._thread_pool_executor.submit(self._update_impressions)

splitio/tests/test_impressions.py

@@ -330,18 +330,6 @@ def setUp(self):
         self.treatment_log = SelfUpdatingTreatmentLog(self.some_api, interval=self.some_interval)
         self.treatment_log.stopped = False
 
-    def test_doesnt_call_submit_if_stopped(self):
-        """Test that _timer_refresh doesn't call submit on the executor pool if it is stopped"""
-        self.treatment_log._stopped = True
-        self.treatment_log._timer_refresh()
-        self.thread_pool_executor.return_value.submit.assert_not_called()
-
-    def test_doesnt_create_timer_if_stopped(self):
-        """Test that _timer_refresh doesn't refresh the timer it is stopped"""
-        self.treatment_log._stopped = True
-        self.treatment_log._timer_refresh()
-        self.timer_mock.assert_not_called()
-
     def test_calls_submit(self):
         """Test that _timer_refresh calls submit on the executor pool if it is not stopped"""
         self.treatment_log._timer_refresh()