avoid generating long lines #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovetskiy
commented
May 14, 2020
go.mod
Outdated
| ) | ||
|
|
||
| replace github.com/moznion/gowrtr => /home/operator/go/src/github.com/moznion/gowrtr |
There was a problem hiding this comment.
will be removed after merging gowrtr
moznion
approved these changes
May 27, 2020
moznion
requested changes
May 31, 2020
There was a problem hiding this comment.
@kovetskiy
I've merged moznion/gowrtr#9 and published v1.5.0 that includes the pull-request.
Could you please change here? https://github.com/moznion/gonstructor/pull/4/files#r425014894
|
@moznion yep, we're good, I've force pushed in order to prevent my go.mod's |
|
Thanks a lot 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this PR we need to merge PR in gowrtr: moznion/gowrtr#9
This PR fixes the problem of really long lines, the difference can be seen here:
reconquest/snake-runner@af5a8ef