fix: audit-deps failure on circular deps in npm audit json and update nsprc to fix audit failure due to DoS advisories in transitive deps#3628
Merged
Conversation
…s dependencies resolution on circular dependencies
…to nsprc ignore list
rpl
changed the title
willdurand
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two small changes:
a small fix to audit-deps script to prevent it to hit an infinite recursion failure if npm audit json includes circular dependencies (which used to be the case due to recent advisory related to eslint dependencies, but it seems to not be reproducing anymore)
new additions to nsprc ignore list for the new DoS related advisories inherited from transitive depedencies (and to be removed once the related dependencies have been updated and the exclusions not needed anymore).
Fixes #3627