feat: Disabled the default browser check for Chromium (#1781) #1782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially closes #1781.
I didn't want to touch DEFAULT_CHROME_FLAGS, as it only contains the default flags of
chromium-launcher
, so that's why I added EXTRA_CHROME_FLAGS. The new list can also be used to add more command line flags in the future, there's plenty to pick from: https://peter.sh/experiments/chromium-command-line-switches/.The thing I'm not sure about is the correctness of my test.