Update to Twemoji v12.1.3 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Emoji v12 support. Make it dev since it's only used for the comparison tests.
emojibase includes them now: milesj/emojibase@24b2398
Makes it easier to find new emojis when updating. Requires switching from compact to full emojibase data.
|
Is there anything blocking the merge so that the v12 update can be released? 4 months with no code review? |
…layout There also seemed to be an error in the zip instructions, saying to use 2/zip as the filelist, while already in the 2 directory.
|
Ping @jfkthame |
|
I'm going to assume this is OK :) ... I was hoping to build the new version locally and take a look, but it's not working for me; seems to be some issues with versions of node stuff, but I don't really know how to disentangle it and get a working build. So I'll assume you can provide a generated font based on the updated sources. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfkthame
Fixes #48