Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sccache lacks basic ratio (percentage) report in --show-stats #2161

Closed
brunvonlope opened this issue Apr 28, 2024 · 2 comments · Fixed by #2211
Closed

sccache lacks basic ratio (percentage) report in --show-stats #2161

brunvonlope opened this issue Apr 28, 2024 · 2 comments · Fixed by #2211
Labels
good first bug For new comers

Comments

@brunvonlope
Copy link

brunvonlope commented Apr 28, 2024

sccache have a very detailed report of some aspects when using --show-stats but I was shocked to see that no ratio of hit or misses is present.

This little detail makes the whole stats feature a bit useless when the project have thousands of objects, since is very hard to compare big numbers.

I see that this was tried in #614 but abandoned by the contributor. Since I don't know if you have some milestone to this feature, I suggest a bit of love into this area for better feature parity with ccache.

@sylvestre
Copy link
Collaborator

I am not sure that I agree with "shocked" and "a bit useless", as these % are easy to compute.

Don't hesitate to propose a PR to implement adding this %

@brunvonlope
Copy link
Author

and "a bit useless", as these % are easy to compute.

Just a note, I restricted the meaning of my sentence to "when the project have thousands of objects". The feature is useful for 99% of use cases, more than the ccache report👍

Don't hesitate to propose a PR to implement adding this %

Unfortunately, I can't contribute in the best way possible (coding), but I thought that worth keeping this issue for tracking purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first bug For new comers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants