Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures introduced by #1086 #1091

Open
marco-c opened this issue Aug 6, 2024 · 8 comments · Fixed by #1125
Open

Fix test failures introduced by #1086 #1091

marco-c opened this issue Aug 6, 2024 · 8 comments · Fixed by #1125

Comments

@marco-c
Copy link
Collaborator

marco-c commented Aug 6, 2024

No description provided.

@marco-c
Copy link
Collaborator Author

marco-c commented Aug 6, 2024

@alexle0nte are you going to work on this?

@alexle0nte
Copy link
Contributor

Yes, I'll create a PR to fix all the tests

@marco-c
Copy link
Collaborator Author

marco-c commented Sep 24, 2024

@alexle0nte are you making progress on this?

@alexle0nte
Copy link
Contributor

alexle0nte commented Sep 25, 2024

@marco-c Yes, #1125 fixes all the metrics tests.
However, there is a problem with repository tests, whose snapshots are contained in rca-output.

Version 0.21.2 of tree-sitter-rust has a bug regarding parsing doc comments, that causes many serde tests to fail.
This bug has been fixed in version 0.23.0, however, upgrading tree-sitter-rust to this version would also require upgrading all other grammars to 0.23.0, but tree-sitter-kotlin doesn't yet support tree-sitter 0.23.0.

In the meantime, I could update the snapshots of all the files that don't contain doc comments, and then, when version 0.23.0 of tree-sitter-kotlin is released, we can do a new grammar upgrade and update the remaining snapshots as well.

@marco-c
Copy link
Collaborator Author

marco-c commented Sep 26, 2024

@alexle0nte do you think we could submit a PR to tree-sitter-kotlin to support 0.23.0 or is it hard?

Your plan seems fine otherwise.

@alexle0nte
Copy link
Contributor

@marco-c I've just opened a PR in tree-sitter-kotlin to bump the tree-sitter dependency to 23.0. Once it's merged and the new release is out, we can upgrade all the grammars to 23.0.

@marco-c
Copy link
Collaborator Author

marco-c commented Sep 27, 2024

Thanks! If it still open in a couple of week, we could create a temporary fork to unblock the updates.

@marco-c marco-c reopened this Sep 30, 2024
@Luni-4
Copy link
Collaborator

Luni-4 commented Sep 30, 2024

@marco-c and @alexle0nte

We can also ask tree-sitter developers if they are willing to adopt the Kotlin grammar among their organization's parsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants