Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-code-analysis-cli -m -p path/to/crate/src/lib.rs does nothing #1087

Closed
jayvdb opened this issue May 16, 2024 · 3 comments
Closed

rust-code-analysis-cli -m -p path/to/crate/src/lib.rs does nothing #1087

jayvdb opened this issue May 16, 2024 · 3 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented May 16, 2024

When I run rust-code-analysis-cli -m -p path/to/crate/src/lib.rs , nothing happens.

According to rust-code-analysis-book/src/commands/metrics.md this should do something.

I am using master with #1084 applied.

@jayvdb jayvdb changed the title rust-code-analysis-cli -m -p libs/ros-helpers/src/lib.rs rust-code-analysis-cli -m -p path/to/crate/src/lib.rs May 17, 2024
@jayvdb
Copy link
Contributor Author

jayvdb commented May 18, 2024

I have got as far with debugging as verifying that fn metrics in spaces.rs is processing the Rust code, but func_space is always false even when there are fns in the file, and the nodes including some of type function_item so it looks like it is finding the fns.

My initial feedback is that it would be nice if the CLI reported something like "No functions found in files analysed".

@jayvdb
Copy link
Contributor Author

jayvdb commented May 18, 2024

Ok, the reason why I am getting no results is #1084 .
When I use #1086 , I get results.

Still, the CLI should give some sort of result if no fns were found.

@jayvdb jayvdb changed the title rust-code-analysis-cli -m -p path/to/crate/src/lib.rs rust-code-analysis-cli -m -p path/to/crate/src/lib.rs does nothing May 18, 2024
@marco-c
Copy link
Collaborator

marco-c commented Aug 6, 2024

Fixed by #1086.

@marco-c marco-c closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants