pdf.js cannot be minified

[kennyx]

I tried Google Closure Tools and YUI Compressor, both of them cannot compress pdf.js

[DanielRuf]

which version of yuicompressor are you using? 2.4.8pre doesnt work (has some syntax errors) but yuicompressor 2.4.4 works

https://github.com/yui/yuicompressor/tags - yuicompressor-35.zip

[kennyx]

v2.4, downloaded from yahoo's official site

[DanielRuf]

from where exactly?
which version? 2.4.x? which x? 2.4.7?
here on github is always the latest version

did you use this pdf.js file?
https://github.com/mozilla/pdf.js/blob/gh-pages/build/pdf.js

i tried it with the 2.4.7 version of yuicompressor and it worked without any errors using the console:
java -jar yuicompressor-2.4.7.jar -o pdf.min.js pdf.js

[andrey-gr]

hi,
I used yuicompressor 2.4.7. (https://github.com/yui/yuicompressor/downloads) to compress pdf.js, and after that i doesn't work for me either. After minification I see following exception in js console:Error:
stream must have data pdf.min.js:1
at cG (http://localhost:8888/lib/plugins/pdf.min.js:1:8200)
at by (http://localhost:8888/lib/plugins/pdf.min.js:1:8799)
at Object.d7 (http://localhost:8888/lib/plugins/pdf.min.js:1:5050)
at Object.d5 (http://localhost:8888/lib/plugins/pdf.min.js:1:4924)
at d9 (http://localhost:8888/lib/plugins/pdf.min.js:1:844286)
at eb (http://localhost:8888/lib/plugins/pdf.min.js:1:845333)
at <error: Error: INVALID_STATE_ERR: DOM Exception 11>

If I change it back to non-minified version, then it renders pdf.

[yurydelendik]

To speed up the execution, the lookup tables is used in the pdf.js code to resolve e.g. glyph names to codes. If compressor/minifier changes the properties names then you will get some kind of error. Adjust compression level so properties will not be renamed, Closing as won't fix

[DanielRuf]

right, also minifying does work
but you have to choose the right options:
http://developer.yahoo.com/yui/compressor/#using

take a look at

--nomunge
      Minify only. Do not obfuscate local symbols.

running yuicompressor with the default settings isnt always the best choice

[andrey-gr]

Hi,
thanks for suggestions.
But it doesn't help. I tried to use all the YUI compressor js options (--nomunge, --disable-optimizations and even --preserve-semi), but it still throws same exception. So for now I'll just use non-minified version.

[DanielRuf]

Then you are doing something wrong because then yuicompressor wont change the variables and so on.

Does the minified version have the right file encoding? Did you try -v or --verbose?
Also you can try google closure compiler which is also very often used and common and should work.

What did you type in your command line?

[andreacfm]

I can confirm this error after minification:

SyntaxError: octal literals and octal escape sequences are deprecated
[Break On This Error]

...-b);var w=n.yMax||y,E=-n.yMin||-b;return"\0$ô\0\0\0�»\0\0\0��»\0\0ß\01...

happens with many tools.

I cannot find a way to min pdf.js. Weird

[DanielRuf]

Hm really weird, maybe someone should file an issue for yuicompressor on GitHub? https://github.com/yui/yuicompressor

https://github.com/tml is the new maintainer

[andreacfm]

Does not make any sense to include a minified version of pdf.js during make process?

[DanielRuf]

Sure, why not? But which compressor works or which one should we use? Did you contact https://github.com/tml?

[andreacfm]

I will write to uglifier guys cause I tested on that system.