Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed change:
Update optional dependency
chokidar
from^2.0.0
to^3.3.0
.This fixes the warning users get when installing:
There are also performance improvements, and
fsevents
no longer has to be built at install. For more information, see: https://paulmillr.com/posts/chokidar-3-save-32tb-of-traffic/The API of v3 is the same as v2, except that dotfiles are no longer ignored by default. I don't think this is relevant for nunjucks. The minimum node version is bumped from v6 to v8, but i'm not sure if that matters considering v6 is no longer in maintenance.
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.