-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release channels and M2M for country and locale #41
Conversation
Fixes bug 1248265.
22d6994
to
0bbea9f
Compare
Fixes bug 1248263.
0bbea9f
to
060dae7
Compare
The release channel change and the M2M changes for country and locale share a lot in common. It was much easier to combine them into one branch, so I did that. |
self.request = request | ||
self.locale = locale | ||
self.release_channel = release_channel | ||
self._country = country |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually just set self.country = country
and it will use that instead of the cached property. So setting it if country isn't None
will let you retain the decorator while allowing it to be set manually.
r+wc, nice work! |
Release channels and M2M for country and locale
Bug 1325797: Do not fail if the dev-mode pref is missing on startup.
@Osmose r?