This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Session extended for fixed activeDuration from now #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great stuff! Thanks! This proposal might help bring consistency on how long the session is extended from the current time. Currently the `createdAt` is update to extend by `activeDuration`, which in-effect extends the session for a varied time from now, i.e. anywhere between `activeDuration` to `duration`. This proposal would extend the session for exactly the `activeDuration` from now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great stuff! Thanks!
This proposal might help bring consistency on how long the session is extended from the current time.
Currently the
createdAtis update to extend byactiveDuration, which in-effect extends the session for a varied time from now, i.e. anywhere betweenactiveDurationtoduration. This proposal would extend the session for exactly theactiveDurationfrom now.