Fix #2069 - #2916
Open
janw-me wants to merge 1 commit into
Open
Conversation
…in container Previously, reopening a container-assigned site only replaced the current tab when it was one of a hardcoded set of built-in "new tab" pages (about:newtab, about:home, etc.). A custom homepage or a new-tab-page replacement extension left an extra tab behind instead of being replaced, since neither matched that static list. isNewTabPage() now also checks the browser's actual homepage/new-tab-page override (via the new browserSettings permission), so it recognizes whatever page the browser or another extension currently treats as the homepage/new-tab page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
Fix the behaviour of #2069
Custom new tabs/home urls will now close when a clicked link is opened in a container.
AI-notice
I fully created this change with Claude.
And I have reviewed the code but Javascript is not the area of expertise.
Also I have tested the code with a new profile in an actual FF browser (152.0.4).
I have fully included me -a human- in the loop.
As far as I could find there is no AI policy.
If this is not allowed or appreciated feel free to close this PR, and my apologies.
Type of change
Select all that apply.
Tag issues related to this pull request: