Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MPEG-4 Part 2 video codec (ISO 14496-2). #294

Open
dreamaniajp opened this issue Apr 8, 2021 · 2 comments
Open

Add support for MPEG-4 Part 2 video codec (ISO 14496-2). #294

dreamaniajp opened this issue Apr 8, 2021 · 2 comments

Comments

@dreamaniajp
Copy link
Contributor

dreamaniajp commented Apr 8, 2021 •
edited
Loading

Hi,
Since current mp4parse-rust doesn't handle MPEG-4 Part 2 video codec(video/mp4v-es, ISO 14496-2),
I tried to add some codes for it.

Is there any concern that I would like to file a pull request to enable it?
And which branch should I work on? master?

Thanks a lot!
@baumanj
Copy link
Contributor

baumanj commented Apr 9, 2021

It's fine if you want to submit a PR for adding this support. Just put it behind a feature flag, as we did with the 3gpp work. When accepted, it will merge into master, but that shouldn't matter for where you do your work. When submitting the PR, it should be as a diff against mozilla:master.

@dreamaniajp
Copy link
Contributor Author

dreamaniajp commented Apr 12, 2021 •
edited
Loading

I created a PR#296 for this.
I use "mp4v" as the feature flag.

Many thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baumanj @dreamaniajp