Skip to content

Conversation

@acmiyaguchi
Copy link
Contributor

bug link

This is a followup to mozilla-services/mozilla-pipeline-schemas#636 and sets payload.hangs[].stack to a string so it will be included in the BigQuery table as a json string.

@acmiyaguchi acmiyaguchi marked this pull request as ready for review December 7, 2020 22:45
@acmiyaguchi
Copy link
Contributor Author

This is the diff generated by running make build && make run on master and bhr-stack in succession.

--- /app/validate_schema_evolution/cdc1f3b904a9bb2f4f9e76c863b0afe169b5a3ac_base-revision/telemetry.bhr.4.txt
+++ /app/validate_schema_evolution/68abdd57c40523eeb1f6644b52732e5c1103eca2_test-generated-schemas/telemetry.bhr.4.txt
@@ -17,2 +17,3 @@
root.environment.addons.active_addons.[].value.description STRING
+root.environment.addons.active_addons.[].value.foreign_install INT64
root.environment.addons.active_addons.[].value.has_binary_components BOOL
@@ -27,2 +28,4 @@
root.environment.addons.active_addons.[].value.update_day INT64
+root.environment.addons.active_addons.[].value.user_disabled INT64
+root.environment.addons.active_addons.[].value.version STRING
root.environment.addons.active_experiment.branch STRING
@@ -30,2 +33,3 @@
root.environment.addons.active_gm_plugins.[].key STRING
+root.environment.addons.active_gm_plugins.[].value.apply_background_updates INT64
root.environment.addons.active_gm_plugins.[].value.user_disabled BOOL
@@ -44,2 +48,3 @@
root.environment.addons.theme.description STRING
+root.environment.addons.theme.foreign_install INT64
root.environment.addons.theme.has_binary_components BOOL
@@ -119,2 +124,4 @@
root.environment.settings.update.enabled BOOL
+root.environment.settings.user_prefs.[].key STRING
+root.environment.settings.user_prefs.[].value STRING
root.environment.system.apple_model_id STRING
@@ -232,2 +239,3 @@
root.payload.hangs.[].runnable_name STRING
+root.payload.hangs.[].stack STRING
root.payload.hangs.[].thread STRING

This is the generated commit: mozilla-services/mozilla-pipeline-schemas@68abdd5

@acmiyaguchi acmiyaguchi requested a review from scholtzan December 7, 2020 23:11
Copy link
Contributor

@scholtzan scholtzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acmiyaguchi acmiyaguchi merged commit ad86d60 into master Dec 7, 2020
@acmiyaguchi acmiyaguchi deleted the bhr-stack branch December 7, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants