Skip to content

Commit e993969

Browse files
committed
Check that status and resolution maps are provided
1 parent b2ebdc4 commit e993969

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

config/config.nonprod.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@
1414
- add_link_to_bugzilla
1515
- add_link_to_jira
1616
- maybe_assign_jira_user
17-
- maybe_update_issue_status
1817
- maybe_update_issue_severity
1918
- sync_whiteboard_labels
2019
- sync_keywords_labels
2120
existing:
2221
- update_issue_summary
2322
- maybe_assign_jira_user
24-
- maybe_update_issue_status
2523
- maybe_update_issue_severity
2624
- sync_whiteboard_labels
2725
- sync_keywords_labels

config/config.prod.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,12 +539,10 @@
539539
- add_link_to_jira
540540
- maybe_assign_jira_user
541541
- maybe_update_issue_status
542-
- maybe_update_issue_resolution
543542
existing:
544543
- update_issue_summary
545544
- maybe_assign_jira_user
546545
- maybe_update_issue_status
547-
- maybe_update_issue_resolution
548546
comment:
549547
- create_comment
550548
status_map:

jbi/models.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,16 @@ def validate_actions(cls, actions: list[Action]):
203203
f"Provide bugzilla_user_id data for `{action.whiteboard_tag}` action."
204204
)
205205

206+
assert action.parameters.status_map or (
207+
"maybe_update_issue_status" not in action.parameters.steps.new
208+
and "maybe_update_issue_status" not in action.parameters.steps.existing
209+
), "`maybe_update_issue_status` was used without `status_map`"
210+
assert action.parameters.resolution_map or (
211+
"maybe_update_issue_resolution" not in action.parameters.steps.new
212+
and "maybe_update_issue_resolution"
213+
not in action.parameters.steps.existing
214+
), "`maybe_update_issue_resolution` was used without `resolution_map`"
215+
206216
return actions
207217

208218
model_config = ConfigDict(ignored_types=(functools.cached_property,))

0 commit comments

Comments
 (0)